Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated roles: init_dbserver, and setup_pgd #584

Merged
merged 7 commits into from
Aug 28, 2023

Conversation

dougortiz
Copy link
Contributor

Updated roles:

  • init_dbserver
  • setup_pgd

All tasks related to:

  • PGD
  • PGD CAMO
  • PGD GROUP COMMIT SCOPES

roles/init_dbserver/tasks/setup_tde.yml Outdated Show resolved Hide resolved
roles/init_dbserver/tasks/validate_init_dbserver.yml Outdated Show resolved Hide resolved
roles/init_dbserver/tasks/verify_tde_vars.yml Show resolved Hide resolved
roles/setup_pgd/tasks/pg_hba_config.yml Outdated Show resolved Hide resolved
roles/setup_pgd/tasks/pgd_cluster_database_owner.yml Outdated Show resolved Hide resolved
roles/setup_pgd/tasks/setup_tde.yml Outdated Show resolved Hide resolved
roles/setup_pgd/tasks/verify_tde_vars.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@hannahms hannahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the commit scope files?

@@ -67,7 +67,7 @@
ansible.builtin.wait_for:
port: "{{ pg_port }}"
state: started
msg: "Port {{ pg_port }} is listening."
msg: "Port {{ pg_port }} is not listening."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this update for?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "Port {{ pg_port }} is listening.", the msg is for when the task succeeds and completes

@@ -9,7 +9,7 @@
become: true
when:
- edb_master_key|length > 0
- pg_data not in edb_master_key_location
- edb_master_key_location not in pg_data
Copy link
Collaborator

@hannahms hannahms Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be pg_data not in edb_master_key_location, the edb_master_key_location is by default in {{ pg_data }}/keys and so the pg_data value would appear in the edb_master_key_location variable, not the other way around.

roles/init_dbserver/tasks/verify_tde_vars.yml Outdated Show resolved Hide resolved
@@ -1,7 +1,7 @@
---
- name: Verify edb_key_wrap_cmd and edb_key_unwrap_cmd
- name: Verify edb_key_wrap_cmd is defined or not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this should change it should read Verify edb_key_wrap_cmd and edb_key_unwrap_cmd are definded

roles/setup_pgd/README.md Show resolved Hide resolved
roles/setup_pgd/tasks/pg_hba_config.yml Outdated Show resolved Hide resolved
roles/setup_pgd/tasks/setup_pgd.yml Outdated Show resolved Hide resolved
roles/setup_pgd/tasks/setup_tde.yml Outdated Show resolved Hide resolved
roles/setup_pgd/tasks/verify_tde_vars.yml Outdated Show resolved Hide resolved
example for configuring two PGD commit scopes is listed below.

The configuration requirements for PGD through the configuration setting variables are:
1. Only one scope can be configured as default at a time. The variable to configure is: `default_group_cs`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

Copy link
Collaborator

@hannahms hannahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update verify_tde_vars and README

ansible.builtin.fail:
msg: "edb_key_wrap_cmd and edb_key_unwrap_cmd are must for initializing a cluster with TDE"
msg: "edb_key_wrap_cmd and edb_key_unwrap_cmd are must for initializing a cluster"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should include something about with TDE, these are not required for initializing a cluster, but are for initializing a cluster with TDE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Comment on lines +133 to +134


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove blank lines

msg: "edb_key_wrap_cmd and edb_key_unwrap_cmd are must for initializing a cluster with TDE"
msg: "edb_key_wrap_cmd and edb_key_unwrap_cmd are must for initializing a cluster"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in init_dbserver

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Collaborator

@hannahms hannahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vibhorkumar123 vibhorkumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vibhorkumar123 vibhorkumar123 merged commit d4883b1 into EnterpriseDB:main Aug 28, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants